Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix octicons_gem including aria-hidden when aria-label is present #295

Merged
merged 2 commits into from
Feb 25, 2019

Conversation

muan
Copy link
Contributor

@muan muan commented Feb 22, 2019

Octicons gem should check for keys of both symbol and string types.


I was unable to run the test locally because it is looking for a mysterious ./build/data.json file, and I can't find instructions for building one locally. 🤔

@muan muan added the a11y label Feb 22, 2019
@muan muan requested review from jonrohan and a team February 22, 2019 23:06
@jonrohan
Copy link
Member

I was unable to run the test locally because it is looking for a mysterious ./build/data.json file, and I can't find instructions for building one locally.

sorry about that. As it stands now, it requires setting up figma api keys to be able to build the data file locally. I'm hoping to add some extra to the code that will pull the last release file data.json if there's no figma api token in someone's env.

Otherwise this looks like a good change! I can get it out next week.

@jonrohan jonrohan mentioned this pull request Feb 25, 2019
7 tasks
@jonrohan jonrohan changed the base branch from master to release-8.5.0 February 25, 2019 20:26
@jonrohan jonrohan merged commit 3e15d9b into release-8.5.0 Feb 25, 2019
@jonrohan jonrohan deleted the aria branch February 25, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants